Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix x/reactions events #940

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jun 27, 2022

Description

This PR fixes the x/reactions events types and missing attributes.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM requested review from leobragaz and dadamu June 27, 2022 12:21
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #940 (02fa0ba) into master (8adb7c9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #940   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         166      166           
  Lines       14014    14015    +1     
=======================================
+ Hits        11598    11599    +1     
  Misses       1943     1943           
  Partials      473      473           
Impacted Files Coverage Δ
x/reactions/keeper/msg_server.go 96.40% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8adb7c9...02fa0ba. Read the comment docs.

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jun 27, 2022
@mergify mergify bot merged commit dbbf84d into master Jun 28, 2022
@mergify mergify bot deleted the riccardom/fix-reactions-events branch June 28, 2022 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants