Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove position validation from post entities and references #941

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Jun 27, 2022

Description

This PR removes the position validation from within a post's entities. This is done to make sure that DApps that store the post's text on other places (i.e. IPFS or any external storage) can use the tags properly.

Before, it wasn't possible to use a tag specifying start and end values that where exceeding a post text length. But for posts that store their text on other storage solutions, it doesn't make sense to check for this. Instead, allowing to specify arbitrary values for start and end indexes allows to support these cases as well.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM requested review from dadamu and leobragaz June 27, 2022 12:28
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@RiccardoM RiccardoM changed the title feat: remove position validation from post entities and references fix: remove position validation from post entities and references Jun 27, 2022
Signed-off-by: Riccardo Montagnin <riccardo.montagnin@gmail.com>
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #941 (019f147) into master (8adb7c9) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #941      +/-   ##
==========================================
- Coverage   82.76%   82.74%   -0.02%     
==========================================
  Files         166      166              
  Lines       14014    14003      -11     
==========================================
- Hits        11598    11587      -11     
  Misses       1943     1943              
  Partials      473      473              
Impacted Files Coverage Δ
x/posts/types/models.go 76.84% <ø> (-0.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8adb7c9...019f147. Read the comment docs.

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Jun 27, 2022
@mergify mergify bot merged commit 8186cab into master Jun 28, 2022
@mergify mergify bot deleted the riccardom/remove-entities-indexes-verification branch June 28, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants