Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix json fields naming of ReportsMsg #961

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

manu0466
Copy link

@manu0466 manu0466 commented Jul 4, 2022

Description

Fixed the json field naming of the struct ReportsMsg used to deserilize the messages received from cosmwasm.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@manu0466 manu0466 added cosmwasm Extend functionality to devs automerge Automatically merge PR once all prerequisites pass labels Jul 4, 2022
@manu0466 manu0466 requested review from leobragaz and dadamu July 4, 2022 16:05
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #961 (05ef88e) into master (7a30b48) will not change coverage.
The diff coverage is n/a.

❗ Current head 05ef88e differs from pull request most recent head 642287a. Consider uploading reports for the commit 642287a to get more accurate results

@@           Coverage Diff           @@
##           master     #961   +/-   ##
=======================================
  Coverage   82.46%   82.46%           
=======================================
  Files         167      167           
  Lines       14243    14243           
=======================================
  Hits        11745    11745           
  Misses       2014     2014           
  Partials      484      484           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c9f72a...642287a. Read the comment docs.

@mergify mergify bot merged commit a42cd60 into master Jul 5, 2022
@mergify mergify bot deleted the manuel/fix-wasm-reports-msg-deserialization branch July 5, 2022 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass cosmwasm Extend functionality to devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants