Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web3.js 1.0.0 support #88

Merged
merged 7 commits into from
Sep 12, 2018
Merged

Web3.js 1.0.0 support #88

merged 7 commits into from
Sep 12, 2018
+2,665 −27

Conversation

krzkaczor
Copy link
Member

@krzkaczor krzkaczor commented Sep 9, 2018 •
edited
Loading

Closes: #25

  • add new target
    • support for basic calls
    • events
  • add tests
    - [ ] fork @types/web3 and improve contracts definition DEFFERED
  • add readme

@krzkaczor krzkaczor changed the title Web3.js 1.0.0 support Web3.js 1.0.0 support [WIP] Sep 9, 2018
@krzkaczor
Copy link
Member Author

After wasting a whole afternoon trying to improve @/types/web3 to work with custom contracts in a nicer way i decided to leave it and require "hard" any cast on consumer side.

@krzkaczor krzkaczor mentioned this pull request Sep 11, 2018
Closed
@krzkaczor krzkaczor changed the title Web3.js 1.0.0 support [WIP] Web3.js 1.0.0 support Sep 12, 2018
@krzkaczor krzkaczor merged commit 652a9c3 into master Sep 12, 2018
@krzkaczor krzkaczor deleted the kk/target-web3-1.0.0 branch September 12, 2018 21:04
@slyfox42 slyfox42 mentioned this pull request Sep 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@krzkaczor