-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enter Circle CI #442
Merged
Merged
Enter Circle CI #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use .resolve() on paths, so that symlinks are properly handled - Use the Path.open syntax of pathlib
I had misunderstood what `.resolve()` does
Somehow searching packages with pkg-config is unable to generate imported targets with the PGI image
CMake won't follow symlink when installing. This commit makes the symlink an actual file to avoid being left with an invalid install tree
Also, pass down definitions in menu.yml to ctest when using dashboard.cmake
This only warns about -std=f2008 not being understood, rather than fail.
Only removes symlinks in its own directory
bast
approved these changes
Aug 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Can be merged at any moment but I recommend that we merge once micro-edits are either applied in the book or we have an item in the TODO doc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set up Circle CI to handle testing with Intel and PGI compilers. Only one recipe fails with Intel, PGI requires a bit more work. Some minor changes to TC need to be applied. I'll make a complete list and clean up history.
Deactivated recipes
Intel
PGI
IMPORTED_TARGET
fails to generate the imported target. Follow up low-prio issue CMake cannot generate imported target with pkg-config and PGI compilers #446IMPORTED_TARGET
fails to generate the imported target. Follow up low-prio issue CMake cannot generate imported target with pkg-config and PGI compilers #446IMPORTED_TARGET
fails to generate the imported target. Follow up low-prio issue CMake cannot generate imported target with pkg-config and PGI compilers #446IMPORTED_TARGET
fails to generate the imported target. Follow up low-prio issue CMake cannot generate imported target with pkg-config and PGI compilers #446IMPORTED_TARGET
fails to generate the imported target. Follow up low-prio issue CMake cannot generate imported target with pkg-config and PGI compilers #446IMPORTED_TARGET
fails to generate the imported target. Follow up low-prio issue CMake cannot generate imported target with pkg-config and PGI compilers #446error stop
Microedits
These have also been noted on the TODO document:
TARGET PkgConfig::ZeroMQ
rather thanZeroMQ_FOUND
TARGET PkgConfig::UUID
rather thanUUID_FOUND
.configurator.py
was rewritten usingpathlib
.generate.py
was rewritten usingpathlib
.evolution.f90
was edited to fix errors with intel.bt-randomgen-example.f90
to fix type mismatch.TARGET PkgConfig::UUID
rather thanUUID_FOUND
.TARGET PkgConfig::UUID
rather thanUUID_FOUND
.Status