Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enter Circle CI #442

Merged
merged 28 commits into from
Aug 12, 2018
Merged

Enter Circle CI #442

merged 28 commits into from
Aug 12, 2018

Conversation

robertodr
Copy link
Collaborator

@robertodr robertodr commented Aug 9, 2018

I've set up Circle CI to handle testing with Intel and PGI compilers. Only one recipe fails with Intel, PGI requires a bit more work. Some minor changes to TC need to be applied. I'll make a complete list and clean up history.

Deactivated recipes

  • 11/2: It's actually only problematic on PGI, but I had to deactivate for both...

Intel

  • 14/3: Sanitizers not supported.

PGI

Microedits

These have also been noted on the TODO document:

  • 3/9: Test with TARGET PkgConfig::ZeroMQ rather than ZeroMQ_FOUND
  • 3/10: Added hints to ZeroMQ library location. These were necessary for the PGI image, where apparently CMake doesn't know how to handle search paths anymore...
  • 5/3: Fortran is needed as language to detect LAPACK when using PGI.
  • 5/4: Fortran is needed as language to detect LAPACK when using PGI.
  • 5/8: Test with TARGET PkgConfig::UUID rather than UUID_FOUND.
  • 6/2: configurator.py was rewritten using pathlib.
  • 6/3: generate.py was rewritten using pathlib.
  • 7/9: evolution.f90 was edited to fix errors with intel.
  • 8/2: Microedits to make it work with Intel.
  • 9/1: Microedit to bt-randomgen-example.f90 to fix type mismatch.
  • 9/1: Require C++11
  • 9/1: Test with TARGET PkgConfig::UUID rather than UUID_FOUND.
  • 10/1,2,3,4: Test with TARGET PkgConfig::UUID rather than UUID_FOUND.

Status

  • Ready to go

- Use .resolve() on paths, so that symlinks are properly handled
- Use the Path.open syntax of pathlib
I had misunderstood what `.resolve()` does
Somehow searching packages with pkg-config is unable to generate
imported targets with the PGI image
CMake won't follow symlink when installing. This commit makes the
symlink an actual file to avoid being left with an invalid install tree
Also, pass down definitions in menu.yml to ctest
when using dashboard.cmake
This only warns about -std=f2008 not being understood,
rather than fail.
Only removes symlinks in its own directory
@robertodr robertodr changed the title [WIP] Enter Circle CI Enter Circle CI Aug 12, 2018
Copy link
Member

@bast bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Can be merged at any moment but I recommend that we merge once micro-edits are either applied in the book or we have an item in the TODO doc.

@bast bast merged commit 676dfbc into dev-cafe:master Aug 12, 2018
@robertodr robertodr deleted the circleci branch August 12, 2018 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants