Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intent of role? #121

Closed
kidbrax opened this issue May 1, 2017 · 9 comments
Closed

intent of role? #121

kidbrax opened this issue May 1, 2017 · 9 comments
Labels

Comments

@kidbrax
Copy link

kidbrax commented May 1, 2017

Is this role intended to make this spec(https://github.com/dev-sec/linux-baseline) pass? Just curious, since that repo links to this role but currently it does not pass that spec.

@rndmh3ro
Copy link
Member

rndmh3ro commented May 1, 2017

The intention is to harden your server but it is done according to the inspec-baseline you linked.
I will update the readme accordingly to clarify this!

@kidbrax
Copy link
Author

kidbrax commented May 1, 2017

So it currently doesn't pass that spec. Is that just because it hasn't been completed yet?

@rndmh3ro
Copy link
Member

rndmh3ro commented May 1, 2017

Where do you see its not passing? Looks good to me: https://travis-ci.org/dev-sec/ansible-os-hardening

@kidbrax
Copy link
Author

kidbrax commented May 1, 2017

Hmm, I'm getting a different result. I'm also showing more tests:

Profile Summary: 33 successful, 17 failures, 0 skipped
Test Summary: 77 successful, 35 failures, 0 skipped

I installed the role using:
ansible-galaxy install dev-sec.os-hardening

Then ran it against my server, then ran the inspec test and got the results above. Is that the correct process?

@kidbrax
Copy link
Author

kidbrax commented May 1, 2017

I just noticed you are passing the --controls switch. When I mimic that, it does pass. Can you provide some clarification on why you don't run all controls?

@rndmh3ro
Copy link
Member

rndmh3ro commented May 1, 2017

Sorry, I forgot to mention that there are missing sysctl-settings in the role. They are currently being added here: #120

The reason there are less (and no failing) tests in travis is, that there the sysctl-tests are missing there. That's because the travis tests run in docker, where you cannot easily set sysctl-parameter.

@kidbrax
Copy link
Author

kidbrax commented May 1, 2017

Gotcha, so the idea is that eventually all specs will pass if run against a regular (non-docker) host?

@rndmh3ro
Copy link
Member

rndmh3ro commented May 1, 2017

Yes, when the PR is merged, then all tests should pass!

@kidbrax
Copy link
Author

kidbrax commented May 1, 2017

Great, thanks for the info!

@kidbrax kidbrax closed this as completed May 1, 2017
rndmh3ro added a commit that referenced this issue Jul 24, 2020
Add comment filter to {{ansible_managed}} string
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
Add comment filter to {{ansible_managed}} string
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants