Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strongly recommend against disabling vfat by default #162

Closed
ageis opened this issue Feb 9, 2018 · 2 comments
Closed

Strongly recommend against disabling vfat by default #162

ageis opened this issue Feb 9, 2018 · 2 comments
Labels

Comments

@ageis
Copy link
Contributor

ageis commented Feb 9, 2018

This should include a huge warning ⚠️ with it. It stopped my system from booting because my EFI partition at /boot/efi is vfat. I later noticed the recommended whitelist in default.yml but many people will apply this role to their systems not expecting things to break so badly.

@rndmh3ro rndmh3ro added the bug label Mar 12, 2018
@wilkis3
Copy link

wilkis3 commented Mar 31, 2018

README.md sad vfat will be disabled.
You can start your os in recovery mode and enable the vfat module.

@rndmh3ro
Copy link
Member

I'll close this issue. It's stated in the docs that vfat gets disabled.

rndmh3ro added a commit to rndmh3ro/linux-baseline that referenced this issue Jul 1, 2018
On UEFI-systems the boot-partition is FAT by default (see [here](https://wiki.archlinux.org/index.php/Unified_Extensible_Firmware_Interface/System_partition)).

If we disable vfat, these systems become unbootable. This has already bitten some users using ansible-os-hardening (dev-sec/ansible-collection-hardening#162, dev-sec/ansible-collection-hardening#145).

Therefore I propose we do not check for a disabled vfat filesystem as vfat is often used on newer systems.
rndmh3ro added a commit to rndmh3ro/linux-baseline that referenced this issue Jul 10, 2018
On UEFI-systems the boot-partition is FAT by default (see [here](https://wiki.archlinux.org/index.php/Unified_Extensible_Firmware_Interface/System_partition)).

If we disable vfat, these systems become unbootable. This has already bitten some users using ansible-os-hardening (dev-sec/ansible-collection-hardening#162, dev-sec/ansible-collection-hardening#145).

Therefore I propose we do not check for a disabled vfat filesystem, if efi is used on these systems
rndmh3ro added a commit that referenced this issue Jul 24, 2020
yaml-lint update, refactor tasks
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
yaml-lint update, refactor tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants