Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it safe to use on Debian 10? The build is failing. #281

Closed
raratiru opened this issue Jul 5, 2020 · 4 comments
Closed

Is it safe to use on Debian 10? The build is failing. #281

raratiru opened this issue Jul 5, 2020 · 4 comments
Labels

Comments

@raratiru
Copy link

raratiru commented Jul 5, 2020

Describe the bug
The version that all tests pass is 5.2.0. Since then (5.2.1, 6.0.0, 6.0.1, 6.0.2, 6.0.3) Debian 10 fails on the tests.

@rndmh3ro
Copy link
Member

rndmh3ro commented Jul 5, 2020

Hey @raratiru,

this role is safe to use with Debian 10!
The tests only fail on travis - I don't know why yet.

Locally with Docker and in a VM with Virtualbox, the role runs without problems:

       PLAY RECAP *********************************************************************
       localhost                  : ok=82   changed=24   unreachable=0    failed=0    skipped=58   rescued=0    ignored=2

       Downloading files from <os-debian10-ansible-latest>
       Finished converging <os-debian10-ansible-latest> (3m53.46s).

The inspec tests run fine, too:

Profile Summary: 17 successful controls, 0 control failures, 38 controls skipped
Test Summary: 57 successful, 0 failures, 38 skipped

@rndmh3ro
Copy link
Member

rndmh3ro commented Jul 5, 2020

The tests fail because of this:

TASK [ansible-os-hardening : protect sysctl.conf] ******************************

fatal: [localhost]: FAILED! => {"changed": false, "msg": "file (/etc/sysctl.conf) is absent, cannot continue", "path": "/etc/sysctl.conf"}

However the file is there locally:

       TASK [ansible-os-hardening : protect sysctl.conf] ******************************
       --- before
       +++ after
       @@ -1,4 +1,4 @@
        {
       -    "mode": "0644",
       +    "mode": "0440",
            "path": "/etc/sysctl.conf"
        }

I don't know why yet. The file gets created when procps is installed. This gets installed locally with test-kitchen, because kitchen uses openssh to connect to the container. And procps is a dependency of openssh.

Travis on the other hand does not use ssh to connect to the container, thus it does not install ssh and no procps.

I'll fix the travis build to install procps.

@rndmh3ro rndmh3ro added the bug label Jul 5, 2020
@rndmh3ro
Copy link
Member

rndmh3ro commented Jul 5, 2020

Fixed by #282

@rndmh3ro rndmh3ro closed this as completed Jul 5, 2020
@raratiru
Copy link
Author

raratiru commented Jul 5, 2020

Thank you @rndmh3ro !

rndmh3ro added a commit that referenced this issue Jul 24, 2020
fix: Ansible part of Fedora build
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this issue Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants