mysql_hardening cannot work with mysql on freebsd

[sdwilsh]

Describe the bug
Due to this line of code, on FreeBSD it is always assumed that the distribution is mariadb because the package name is mysql80-server, not mysql-server.

Expected behavior
Either the system detects the right package or it is allowed to be user-overridden.

Actual behavior

TASK [devsec.hardening.mysql_hardening : get all users that have no authentication_string on MySQL version >= 5.7.6 or Mariadb version >= 10.4.0] ***************************************************************
skipping: [mysql.hogs.tswn.us]

TASK [devsec.hardening.mysql_hardening : get all users that have no password or authentication_string on MySQL version < 5.7.6 or Mariadb version < 10.4.0] *****************************************************
fatal: [mysql.hogs.tswn.us]: FAILED! => {"changed": false, "msg": "Cannot execute SQL 'SELECT GROUP_CONCAT(QUOTE(USER), '@', QUOTE(HOST) SEPARATOR ', ') AS users FROM mysql.user WHERE (length(password)=0 OR password=\"\") AND (length(authentication_string)=0 OR authentication_string=\"\") AND USER NOT IN ('mysql.sys', 'mysqlxsys', 'mariadb.sys');' args [None]: (1054, \"Unknown column 'password' in 'where clause'\")"}

Notably, if I ask mysql what version it is running, it properly reports version 8.0.25

Example Playbook

n/a - this is pretty obvious what is going on

OS / Environment

FreeBSD 12.2

Ansible Version

ansible 2.10.12
  config file = /home/sdwilsh/ansible-playbooks/ansible.cfg
  configured module search path = ['/home/sdwilsh/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python3/dist-packages/ansible
  executable location = /usr/bin/ansible
  python version = 3.8.10 (default, Jun  2 2021, 10:49:15) [GCC 9.4.0]

Role Version

7.9.0

Additional context

Everything else about this playbook works, although I do have to set a number of variables in order to get this far.

[sdwilsh]

Everything else about this playbook works, although I do have to set a number of variables in order to get this far.

Just to elaborate on this, since this failing piece of code is pretty early, I know other stuff works because I was running with --check --diff and seeing what the changes would be before I actually ran it and got this error.

[rndmh3ro]

Making the variable user-overridable seems like the best idea. Something like this:

- name: Check if MySQL or MariaDB is used
  set_fact:
    mysql_distribution: "{{ ansible_facts.packages['mysql-server'] is defined | ternary('mysql', 'mariadb') }}"
  when: not mysql_distribution

Do you weant to create a PR for this?

[sdwilsh]

I can do that, but I wanted to make sure this was something y'all would take. I can also do a second PR for getting some of the platform variables for FreeBSD defined, if you'd like.

[rndmh3ro]

I'd like both PRs! :)