remove execshield sysctl-parameter on rhel7 #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndmh3ro
changed the title
rndmh3ro
changed the title
|
Travis fails because of the errors that are fixed in #138. |
ypid
approved these changes
Aug 6, 2017
tasks/main.yml
Outdated
| - '{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.yml' | ||
| - '{{ ansible_distribution }}.yml' | ||
| - '{{ ansible_os_family }}-{{ ansible_distribution_major_version }}.yml' | ||
| - '{{ ansible_os_family }}.yml' |
There was a problem hiding this comment.
Maybe include {{ ansible_os_family }}.yml always a first task and then have a second task which does the with_first_found? This way redundancy could be decreased.
There was a problem hiding this comment.
Can you expand on this? I don't understand how this decreased redundancy.
There was a problem hiding this comment.
Something like this:
- name: Set OS family dependent variables
include_vars: '{{ ansible_os_family }}.yml'
- name: Set OS dependent variables
include_vars: '{{ item }}'
with_first_found:
- '{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.yml'
- '{{ ansible_distribution }}.yml
- '{{ ansible_os_family }}-{{ ansible_distribution_major_version }}.yml'Then {{ ansible_os_family }}.yml could contain all the basics and other files could be kept at a minimum.
ypid
reviewed
Aug 7, 2017
vars/RedHat.yml
Outdated
| owner: root | ||
| group: root | ||
| mode: '0644' | ||
|
|
There was a problem hiding this comment.
Yeah, well. I don't know.
rndmh3ro
added a commit
that referenced
this pull request
Jul 24, 2020
use package instead of yum so the operation works on Fedora
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
use package instead of yum so the operation works on Fedora
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
remove execshield sysctl-parameter on rhel7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're having code-duplicates here, but I still think its the cleanest solution, as I don't want to include more conditionals to check for than necessary.
Fixes #118