-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add travis-support #17
Conversation
looks like we should not disable ipv6 for travis test |
We have to merge #16 first, then travis should work. |
Build is still failing, this time because of insufficent permissions:
My plan is to add to the failing task(s) a tag (e.g.
|
cant we write all options into travis.yml. then everything would be in one place. otherwise we mix the implementation with specific edge cases |
To skip single tasks you have to specify tags and then use the
In
Or we could use conditionals on all problematic tasks and evaluate them to false just like here:
But then we could not use #20. |
@rndmh3ro Thanks for pointing this out. I definitely like #20. Instead of skipping complete tasks, we could also overwrite the parameter values and switch back to os defaults for travis playbook for required parameters: https://docs.ansible.com/playbooks_variables.html#variables-defined-in-a-playbook What do you think? |
I cannot get it to work. Even though when a sysctl-variable doesn't get changed, traivis throws errors at me. |
we do not use travis vms for applying hardening, instead we opt in for a separate jenkins setup |
Then, I'd say we exclude the sysctl-tasks from travis. I can confirm that it works locally. Nonetheless all other tasks should work with travis! |
amazing. let's do this |
I think this is ready for merging now, @chris-rock. Would be great if you could do it. |
amazing work @rndmh3ro |
I rebased the branch on master. If this goes through, I'll merge. |
@rndmh3ro Could you have a look, what is going wrong? |
Thank you very much. As I said, amazing work! |
No description provided.