Use ansible facts for vars #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Talbot <hello+github@jtalb.com>
Signed-off-by: Joshua Talbot <hello+github@jtalb.com>
This was referenced Jun 30, 2019
|
Hey @joshuatalb, thanks for ypur PR, looks great! :) I had to change two things: |
|
BTW: These changes would be very welcome in our other repos: |
|
Ah - good spot @rndmh3ro. You have better eyes than I do, clearly! Thanks for merging; will look to try and contribute some more soon when time permits. |
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Use ansible facts for vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a spin-off of #225 as that PR became slightly bloated and a
gitcommand on a new pc barfed, accidentally pushing bad commits.This PR changes the code to use
ansible_factsas per @rndmh3ro's request in #225 and splits the aformentioned PR into smaller pieces, allowing for easier peer review.Please let me know if you have any comments.
cc: @rndmh3ro
--
This PR also fixes #223.