Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restart-auditd handler #260

Closed

Conversation

snoopotic
Copy link
Contributor

add restart-auditd handler as after configuration change (e.g. of os_auditd_max_log_file_action) you need to restart.
Sadly on rhel7 systems you cannot use systemd. And as debian derivates use service as alias and it works I kept it that simple but ugly.
Also adding 'auditd'-tag to make it easy only run that config change if needed.

@snoopotic snoopotic force-pushed the fix/add_auditd_restart_handler branch from af3b648 to deb93bc Compare February 13, 2020 13:22
Copy link
Member

@rndmh3ro rndmh3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Felix,
Thanks for this PR!
I got some comments on your code, can you please check them?

tasks/auditd.yml Outdated Show resolved Hide resolved
handlers/main.yml Show resolved Hide resolved
…auditd_max_log_file_action) you need to restart. Sadly on rhel7 systems you cannot use systemd. And as debian derivates use service as alias and it works I kept it that simple. also adding 'auditd'-tag to make it easy only run that config change if needed.

Signed-off-by: Felix Herzog <snoopotic@gmail.com>
…viour. also removing tags on redundant places as suggested.

Signed-off-by: Felix Herzog <snoopotic@gmail.com>
@snoopotic snoopotic force-pushed the fix/add_auditd_restart_handler branch from 4f4bfde to d0be705 Compare February 15, 2020 14:24
@snoopotic
Copy link
Contributor Author

I pushed the requested changes.
I had to rebase the previous commit and force-push because I hat committed and signed off with the wrong account, this is fixed, too.

…ing behaviour. also removing tags on redundant places as suggested."

service module sadly cannot be tested as systemd is not working properly in did-environments. thus rolling back to cmd behaviour.

This reverts commit d0be705.

Signed-off-by: Felix Herzog <snoopotic@gmail.com>
Signed-off-by: Felix Herzog <snoopotic@gmail.com>
@snoopotic snoopotic force-pushed the fix/add_auditd_restart_handler branch from 48cd7d7 to f4c9aac Compare February 23, 2020 08:57
rndmh3ro pushed a commit that referenced this pull request Jul 24, 2020
As discussed in #260, 2fa does not really belong in a role for
configuring ssh.

Signed-off-by: Dennis Eriksen <d@ennis.no>
rndmh3ro pushed a commit that referenced this pull request Jul 24, 2020
As discussed in #260, 2fa does not really belong in a role for
configuring ssh.

Signed-off-by: Dennis Eriksen <d@ennis.no>
@rndmh3ro
Copy link
Member

superseeded by #427

@rndmh3ro rndmh3ro closed this Mar 19, 2021
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
As discussed in dev-sec#260, 2fa does not really belong in a role for
configuring ssh.

Signed-off-by: Dennis Eriksen <d@ennis.no>
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
As discussed in dev-sec#260, 2fa does not really belong in a role for
configuring ssh.

Signed-off-by: Dennis Eriksen <d@ennis.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants