-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add restart-auditd handler #260
Closed
snoopotic
wants to merge
4
commits into
dev-sec:master
from
snoopotic:fix/add_auditd_restart_handler
Closed
add restart-auditd handler #260
snoopotic
wants to merge
4
commits into
dev-sec:master
from
snoopotic:fix/add_auditd_restart_handler
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoopotic
force-pushed
the
fix/add_auditd_restart_handler
branch
from
February 13, 2020 13:22
af3b648
to
deb93bc
Compare
rndmh3ro
requested changes
Feb 14, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Felix,
Thanks for this PR!
I got some comments on your code, can you please check them?
…auditd_max_log_file_action) you need to restart. Sadly on rhel7 systems you cannot use systemd. And as debian derivates use service as alias and it works I kept it that simple. also adding 'auditd'-tag to make it easy only run that config change if needed. Signed-off-by: Felix Herzog <snoopotic@gmail.com>
…viour. also removing tags on redundant places as suggested. Signed-off-by: Felix Herzog <snoopotic@gmail.com>
snoopotic
force-pushed
the
fix/add_auditd_restart_handler
branch
from
February 15, 2020 14:24
4f4bfde
to
d0be705
Compare
I pushed the requested changes. |
…ing behaviour. also removing tags on redundant places as suggested." service module sadly cannot be tested as systemd is not working properly in did-environments. thus rolling back to cmd behaviour. This reverts commit d0be705. Signed-off-by: Felix Herzog <snoopotic@gmail.com>
Signed-off-by: Felix Herzog <snoopotic@gmail.com>
snoopotic
force-pushed
the
fix/add_auditd_restart_handler
branch
from
February 23, 2020 08:57
48cd7d7
to
f4c9aac
Compare
rndmh3ro
pushed a commit
that referenced
this pull request
Jul 24, 2020
As discussed in #260, 2fa does not really belong in a role for configuring ssh. Signed-off-by: Dennis Eriksen <d@ennis.no>
rndmh3ro
pushed a commit
that referenced
this pull request
Jul 24, 2020
As discussed in #260, 2fa does not really belong in a role for configuring ssh. Signed-off-by: Dennis Eriksen <d@ennis.no>
superseeded by #427 |
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
As discussed in dev-sec#260, 2fa does not really belong in a role for configuring ssh. Signed-off-by: Dennis Eriksen <d@ennis.no>
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
As discussed in dev-sec#260, 2fa does not really belong in a role for configuring ssh. Signed-off-by: Dennis Eriksen <d@ennis.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add restart-auditd handler as after configuration change (e.g. of os_auditd_max_log_file_action) you need to restart.
Sadly on rhel7 systems you cannot use systemd. And as debian derivates use service as alias and it works I kept it that simple but ugly.
Also adding 'auditd'-tag to make it easy only run that config change if needed.