Fix two sysctl-settings #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -83,7 +83,7 @@ sysctl_config: | |||
| # This settings controls how the kernel behaves towards module changes at | |||
| # runtime. Setting to 1 will disable module loading at runtime. | |||
| # Setting it to 0 is actually never supported. | |||
| kernel.modules_disabled: 1 | |||
| # kernel.modules_disabled: 1 | |||
There was a problem hiding this comment.
Why have you commented this out? Is the default behavior 0?
There was a problem hiding this comment.
The tests specify that this value should be zero:
context linux_kernel_parameter('kernel.modules_disabled') do
its(:value) { should eq 0 }
end
However setting this variable to 0 with Ansible results in an error, because 0 is not supported. That's why I commented it out. The user has to enable the setting by himself.
There was a problem hiding this comment.
Great. Thanks for the clarification
chris-rock
force-pushed
the
sysctl_bugfix
branch
from
8497c4a
to
f6cf4fc
Compare
|
Thanks for the fix @rndmh3ro |
rndmh3ro
pushed a commit
that referenced
this pull request
Jul 24, 2020
Fix join-filter, jinja-cases, intendation
rndmh3ro
added a commit
that referenced
this pull request
Jul 24, 2020
Add CentOS7 with MariaDB support
rndmh3ro
pushed a commit
that referenced
this pull request
Jul 24, 2020
Closes: #26 Signed-off-by: Moritz Schlarb <moschlar@metalabs.de>
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Fix join-filter, jinja-cases, intendation
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
Closes: dev-sec#26 Signed-off-by: Moritz Schlarb <moschlar@metalabs.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
arp_announce should be 2.
I commented out
kernel.modules_disabledso it doesn't get set at all.