do not blacklist used filesystems #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some systems seem to require vfat because of efi, despite not exposing a /sys/firmware/efi directory. Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
|
solves #288 |
rndmh3ro
reviewed
Aug 5, 2020
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
so we don't break existing mounts with our configuration Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
|
@rootbox can you test this PR? |
|
tests are failing on el6 because of this: https://wrightturn.wordpress.com/2017/05/25/ansible-map-not-available-on-el6/ |
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
schurzi
changed the title
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
|
Thanks! |
I'm sorry for my late reply: yes it works perfectly fine! |
rndmh3ro
added a commit
that referenced
this pull request
Nov 8, 2020
unify changelog and release actions
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
unify changelog and release actions
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
* add additional check for efi some systems seem to require vfat because of efi, despite not exposing a /sys/firmware/efi directory. Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * make linter happy Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * rework check to check for all used filesystems so we don't break existing mounts with our configuration Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * do not check this on el6 Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * add comment to clarify Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some systems seem to require vfat because of efi, despite not exposing a
/sys/firmware/efi directory.
Signed-off-by: Martin Schurz Martin.Schurz@t-systems.com