Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file permissions explicitly defined #300

Merged
merged 3 commits into from
Aug 18, 2020
Merged

file permissions explicitly defined #300

merged 3 commits into from
Aug 18, 2020

Conversation

danielkubat
Copy link
Contributor

due to breaking change in recent ansible-lint release, we need to add file permissions (mode) - there are no default ones anymore due to security concerns.

fixes: #299

Signed-off-by: danielkubat dan.kubat@gmail.com

Signed-off-by: danielkubat <dan.kubat@gmail.com>
Signed-off-by: danielkubat <dan.kubat@gmail.com>
@schurzi
Copy link
Contributor

schurzi commented Aug 18, 2020

thank you for this nice pro-active PR!
for sake of consistency, could you put all modes in single quotes? so we are using the same formatting in the whole module.

Signed-off-by: danielkubat <dan.kubat@gmail.com>
@schurzi schurzi merged commit 989f7b0 into dev-sec:master Aug 18, 2020
rndmh3ro added a commit that referenced this pull request Nov 8, 2020
wkhayrattee added a commit to wak-automation/ansible-os-hardening that referenced this pull request Nov 27, 2021
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
…11forward

allow customization of X11Forwarding
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
define file permissions explicitly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change in ansible-lint - set file permissions explicitly
3 participants