change inclusion of os specific defaults #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schurzi
force-pushed
the
default_handling
branch
2 times, most recently
from
b42e87e
to
63f86a2
Compare
|
seems to work allright. but we need to rollback the changes from #351 if we decide to go down this path |
schurzi
force-pushed
the
default_handling
branch
from
e056079
to
4e4aaad
Compare
schurzi
changed the title
we now include the os specific options into a separate variable and merge this with the default ansible namespace, when the corresponding keys do not already exist (eg. are defined by default oder by user) Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
schurzi
force-pushed
the
default_handling
branch
from
206cd82
to
5e9f9d9
Compare
schurzi
force-pushed
the
default_handling
branch
from
5e9f9d9
to
d033d0e
Compare
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
schurzi
force-pushed
the
default_handling
branch
from
d033d0e
to
5ff0eec
Compare
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
|
interesting, the I have currently no idea why Ubuntu 20 is failing. |
rndmh3ro
reviewed
Dec 20, 2020
|
LGTM, just two minor docs-issues. |
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
* change inclusion of os specific defaults we now include the os specific options into a separate variable and merge this with the default ansible namespace, when the corresponding keys do not already exist (eg. are defined by default oder by user) Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * simplify check for os specific variables Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * add test for variable override Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * move tests to verify stage Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * correct grep Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * linting Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * fix typo Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * Revert "Merge pull request dev-sec#351 from sprat/fix-umask" This reverts commit 9e8e0bc, reversing changes made to 98c7553. Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * move immutable ssh vars to internal vars Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * move vars to OS files Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * change default handling for all roles Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * fix issues Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * add documentation Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com> * Update main.yml Co-authored-by: Sebastian Gumprich <rndmh3ro@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we now include the os specific options into a separate variable and
merge this with the default ansible namespace, when the corresponding
keys do not already exist (eg. are defined by default oder by user)
Signed-off-by: Martin Schurz Martin.Schurz@t-systems.com