Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercased first letter of task names. #419

Closed
wants to merge 1 commit into from
Closed

Uppercased first letter of task names. #419

wants to merge 1 commit into from

Conversation

joubbi
Copy link
Contributor

@joubbi joubbi commented Mar 15, 2021

I uppercased the first letter of all task names.
Most of the names were all lowercase but there were some that had an uppercase first letter.

My motivation:
It looks better when running the tasks.
All of the examples in latest official Ansible documentation have it this way.
It's better to have it look the same everywhere.

I did a replace like this:
sed -r -i 's/(-\ name:\ )(.)/\1\U\2/g' *
and then modified the few "notify" lines.

Signed-off-by: Farid Joubbi farid@joubbi.se

Signed-off-by: Farid Joubbi <farid@joubbi.se>
@schurzi
Copy link
Contributor

schurzi commented Mar 16, 2021

@joubbi sorry I did a large merge this morning, that genereated conflicts, can you please rebase?
Also you renamed some handlers and did not cover the places they are called (in nginx for example) can you take a look at the failing CI tasks? (mysql on ubuntu 2004 should be failing because of different problems, all otrhers should be green)

@joubbi
Copy link
Contributor Author

joubbi commented Mar 16, 2021

I can fix it.
I noticed from the CI output that I had missed a file.

Are you okay with this change (other than the failing notify)? I don't want to step on anyone's toes.

@schurzi
Copy link
Contributor

schurzi commented Mar 16, 2021

I have no strong oppionions about this. It sure looks a bit nicer if we uppercase starting letters.
I'd say go for it, if you like to do this. Though I cannot gurantee that it stays this way forever. :s

@rndmh3ro
Copy link
Member

Now that #422 is merged, this can be closed I guess?

@schurzi schurzi closed this Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants