Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mysql_hardening] Setup defaults for MySQL on FreeBSD #474

Merged
merged 1 commit into from
Aug 20, 2021
Merged

[mysql_hardening] Setup defaults for MySQL on FreeBSD #474

merged 1 commit into from
Aug 20, 2021

Conversation

sdwilsh
Copy link
Contributor

@sdwilsh sdwilsh commented Aug 13, 2021

This is not very useful without #473.

@sdwilsh
[mysql_hardening] Setup defaults for MySQL on FreeBSD
5a1bf14 
Signed-off-by: Shawn Wilsher <656602+sdwilsh@users.noreply.github.com>
@sdwilsh
Copy link
Contributor Author

sdwilsh commented Aug 13, 2021

It's worth noting that the mysql_datadir is in a different place too, but that would be a bigger change (that I can make) to move that to the vars for all the other platform from defaults.

sdwilsh added a commit to sdwilsh/ansible-playbooks that referenced this pull request Aug 13, 2021
@sdwilsh
Updates for fixes for devsec.hardening.mysql_hardening
914943b 
Everything after the TODO can be removed after these two PRs are
released:
* dev-sec/ansible-collection-hardening#473
* dev-sec/ansible-collection-hardening#474
@rndmh3ro
Copy link
Member

LGTM.

but that would be a bigger change (that I can make) to move that to the vars for all the other platform from defaults.

If we go this route to support FreeBSD, then I'd like to see some automated tests for this OS. Currently we use molecule with Docker to test the different OS. Does an image for BSDs exist?

@rndmh3ro rndmh3ro merged commit 3b33e0a into dev-sec:master Aug 20, 2021
@schurzi
Copy link
Contributor

schurzi commented Aug 20, 2021

Does an image for BSDs exist?

I had a look into this and it seems, there is currently no feasible option to run FreeBSD images in GitHub CI. THere may be some obscure way via MacOS hosts and VM images. But this is nothing I want to have in our pipeline.

@sdwilsh
Copy link
Contributor Author

sdwilsh commented Aug 20, 2021

I found the same vm image option, and I was nonplussed by it as well. I will happily file issues as they come up for freebsd, which I know is not ideal, but better than nothing.

@sdwilsh sdwilsh deleted the freebsd-defaults branch August 20, 2021 14:36
divialth pushed a commit to divialth/ansible-collection-hardening that referenced this pull request Aug 3, 2022
@sdwilsh
[mysql_hardening] Setup defaults for MySQL on FreeBSD (dev-sec#474)
8984cf2 
Signed-off-by: Shawn Wilsher <656602+sdwilsh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement minor mysql_hardening
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdwilsh @rndmh3ro @schurzi