Add explicit role-path to kitchen.yml #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this PR role path was searched with regex in the docroot. Now it's explicitly declared. Also added two gems to gemfile for faster copying to virtualbox
chris-rock
force-pushed
the
add_explicit_role_to_kitchen
branch
from
d16221b
to
1e08e56
Compare
|
Hi @rndmh3ro I have troubles with the kitchen tests. Are those running through on your machine? |
|
What problem exactly do you have? I found a problem. Can you remove the following lines and try again? https://github.com/hardening-io/ansible-os-hardening/blob/master/.kitchen.yml#L49-L50 |
|
@rndmh3ro The ansible implementation is great, I just have issues with busser tests. |
|
@rndmh3ro Solved it. Looks like we need |
|
Thanks for this improvement @rndmh3ro |
chris-rock
added a commit
that referenced
this pull request
Nov 28, 2015
Add explicit role-path to kitchen.yml
rndmh3ro
pushed a commit
that referenced
this pull request
Jul 24, 2020
update platforms in meta-file
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
update platforms in meta-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR role path was searched with regex in the docroot.
Now it's explicitly declared.
Also added two gems to gemfile for faster copying to virtualbox and ansible diff.