Updates handlers for new ansible syntax and deprecated options for legacy commands #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes the handler file and set new syntax Signed-off-by: Jacob Sievert <jacob.sievert@sievert-mail.de>
|
What's the reason you used |
|
Hmm you are right that ansible.builtin.command would be better, thought that the deprecation of the direct command module was already in the pipeline. |
Signed-off-by: Jacob Sievert <jacob.sievert@sievert-mail.de>
|
Thanks! |
rndmh3ro
pushed a commit
to CaptainSifff/ansible-collection-hardening
that referenced
this pull request
Nov 28, 2022
…gacy commands (dev-sec#602) * Update main.yml fixes the handler file and set new syntax Signed-off-by: Jacob Sievert <jacob.sievert@sievert-mail.de> * changes command module from legacy to builtin. Signed-off-by: Jacob Sievert <jacob.sievert@sievert-mail.de> Signed-off-by: Jacob Sievert <jacob.sievert@sievert-mail.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes the handler file and set new syntax