add check mode to molecule tests #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
github-actions
bot
added
mysql_hardening
nginx_hardening
os_hardening
ssh_hardening
labels
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
schurzi
commented
Mar 1, 2023
|
So I have looked through a few outputs of the molecule tests and I believe this works now. As to verifying this automatically I have almost no Idea how to ensure it keeps that way. Comparing the check run to the actual run not a good option, since some stuff always differs and not every module we use supports check mode in a good way. I believe, this is as far as we get with molecule. If we really want to make it great, we would need an additional test framework. https://github.com/HewlettPackard/monkeyble seems great for this task. |
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
|
Thanks! Let's see, if we encounter more problems along the way that justify using monkeyble. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.