Adds support for CentOS 7 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 25, 2016 22:43
Uses a two-pass approach that inspects all target directories, then only operates on the true "directories," skipping the symlinks, if any. Using the "recurse=true" parameter ensures that the suid/sgid modifications are applied to files as well as directories.
It appears that the sysctl_set parameter overrides ignorerrors. Since we fully expect `kernel.exec_shield` to be handled differently on CentOS 7+, where it is is no longer configurable, let's preserve the functionality provided by ignorerrors.
|
Thanks for this, good work! :-) |
divialth
pushed a commit
to divialth/ansible-collection-hardening
that referenced
this pull request
Aug 3, 2022
use new docker images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CentOS 7 introduced some breaking changes for the role, namely:
/bin->/usr/bin,/sbin->/usr/sbinkernel.exec_shieldsysctl parameter no longer configurableThis PR addresses the changes and provides backwards-compatible support for CentOS 7. Of particular note is the undocumented behavior of the sysctl Ansible module where use of the "sysctl_set" parameter overrides the "ignoreerrors" parameter. Was maddening to debug, but got to the bottom of it eventually.
There are still a few failing tests here, but pending inclusion of the new inspec suite and potentially the docker integration, I'm submitting anyway. The PR does indeed fix a few outstanding issues, so it warrants review for inclusion.
Fixes #71. Fixes #74. Supersedes and therefore closes #77.