use new docker files #26
Conversation
rndmh3ro
force-pushed
the
new_dockerimages
branch
3 times, most recently
from
19046a4
to
179637d
Compare
rndmh3ro
force-pushed
the
new_dockerimages
branch
from
179637d
to
6e2a25d
Compare
.kitchen.vagrant.yml
Outdated
| max_ssh_sessions: 5 | ||
|
|
||
| platforms: | ||
| - name: ubuntu-12.04 |
.kitchen.vagrant.yml
Outdated
| box: opscode-ubuntu-12.04 | ||
| box_url: https://opscode-vm-bento.s3.amazonaws.com/vagrant/virtualbox/opscode_ubuntu-12.04_chef-provisionerless.box | ||
| - name: ubuntu-14.04 | ||
| driver_config: |
There was a problem hiding this comment.
driver_config is not needed since it defaults to bento boxes
| box_url: https://opscode-vm-bento.s3.amazonaws.com/vagrant/virtualbox/opscode_debian-8.1_chef-provisionerless.box | ||
| - name: centos6-ansible-latest | ||
| driver: | ||
| image: rndmh3ro/docker-centos6-ansible:latest |
There was a problem hiding this comment.
docker stuff should be in .kitchen.docker.yml
There was a problem hiding this comment.
Docker is the default testing method in this role. What else should be there then?
There was a problem hiding this comment.
hmm ok, looks like the other repos are non-standard as well so ignore this commend then :)
There was a problem hiding this comment.
Actually I'll change this to the bento boxes. I just discovered that bento has all of them.
| @@ -1,62 +1,77 @@ | |||
| --- | |||
| driver: | |||
| name: vagrant | |||
| name: docker | |||
There was a problem hiding this comment.
Ẁhat's the difference and advantages?
There was a problem hiding this comment.
I took a look at https://github.com/someara/kitchen-dokken.
It sounds good, but right now we use kitchen-docker in all our ansible-roles. So I'l write it on my todo-list to check out dokken.
There was a problem hiding this comment.
Take a look at https://github.com/dev-sec/chef-mysql-hardening/blob/master/.kitchen.yml
tl;dr dokken abstracts away from of the docker stuff that you don't care about in a CI environment (i.e. the run_opts and initoptions you have in the travis config)
Your config looks like it works fine the way it is, so just a thought if you have time or for the future :)
|
Travis green, does someone have any objections against merging? |
|
LGTM |
This uses my own docker images (https://github.com/rndmh3ro/docker-ansible). These are just the base images with pre-installed Docker to save time and hassle when testing the roles.
This also enables full travis testing of all supported operating systems!
This too removes ansible 1.9 support, to better test the role. Also there's no more support for Ansible < 2.0, see https://groups.google.com/forum/#!topic/ansible-devel/6-6FdxZ94kc.
This also updates .kitchen.vagrant.yml same way as in PR dev-sec/ansible-collection-hardening#113.