Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper testing if kernel modules are disabled #163

Merged
merged 1 commit into from
May 31, 2017
Merged

Proper testing if kernel modules are disabled #163

merged 1 commit into from
May 31, 2017

Conversation

artem-sidorenko
Copy link
Member

@artem-sidorenko artem-sidorenko commented May 22, 2017

This is required by dev-sec/linux-baseline#62

Signed-off-by: Artem Sidorenko <artem@posteo.de>
@coveralls
Copy link

coveralls commented May 22, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling f496450 on modules into 2c68b00 on master.

@artem-sidorenko
Copy link
Member Author

@atomic111 can you maybe review this? Chris is probably totally busy because of chefconf

@artem-sidorenko
Copy link
Member Author

artem-sidorenko commented May 27, 2017

@atomic111 'fix' for debian-7 is in dev-sec/linux-baseline#63

Regarding fedora - this is a well-known problem with dnf and chef (chef/bento#709). I'll have a look if its already fixed or not and how to have a workaround here. So lets ignore broken fedora tests for now

Copy link
Member

@atomic111 atomic111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artem-sidorenko thanks for the fix

@atomic111 atomic111 merged commit e2261fb into master May 31, 2017
@artem-sidorenko artem-sidorenko deleted the modules branch May 31, 2017 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants