Parameterise Banner and DebianBanner as attributes #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit parameterises `Banner` and `DebianBanner` in the sshd config with the attributes `['ssh']['banner']` and `['ssh']['os_banner']` respectively, though the latter is only supported on Debian family distributions. Debian based distributions will have `DebianBanner no` set by default from now on.
|
@tsenart thanks for your PR, but there is the error with the oracle machine. Can you fix this please? Than i can merge it. if you need help let me know |
|
@atomic111: I'm not sure what the issue is. Would you have any leads? |
|
@tsenart this looks strange, because it is working on my local machine. i am working on this |
|
@tsenart I solved it. It was a little problem with travis. Thank you for the great PR |
artem-sidorenko
added a commit
to artem-forks/chef-ssh-hardening
that referenced
this pull request
Dec 22, 2016
artem-sidorenko
added a commit
to artem-forks/chef-ssh-hardening
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit parameterises
BannerandDebianBannerin the sshd configwith the attributes
['ssh']['banner']and['ssh']['os_banner']respectively,though the latter is only supported on Debian family distributions.
Debian based distributions will have
DebianBanner noset by defaultfrom now on.