-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable SSH Banner File #130
Conversation
@sidxz thank you for PR! As different distros use different banner file, maybe we can provide reasonable defaults for each distribution? Like we do for package or service names |
@artem-sidorenko Thanks, that's surely a much better way to do it! |
@sidxz thank you! I've checked ubuntu 16.04, centos 7 and opensuse-leap-42.1. They all have
Still if it might get to a such "broken" banner, I would suggest to stick to
@atomic111 any other opinion? |
this sounds good. may be we add a attribute to configure the text in the issue.net file. @artem-sidorenko and @sidxz What do think? |
@sidxz what about to use |
Thanks for replying @atomic111 and @artem-sidorenko. Thanks |
@sidxz the idea of @atomic111 makes sense here as well. Example: within my org issue.net is mostly used for a usual "...your actions might be observed..."-disclaimer without any further information. In this use case this idea might be pretty useful Anyway, lets go with your current suggestion, its the most flexible and simple in the same time;-) could you please cleanup the commit history via squashing the commits? |
@sidxz could you also please add a line to the |
…ile or to disable it
@sidxz thank you! |
@artem-sidorenko, @atomic111 Thank you! |
Path to the Banner File in template 'opensshd.conf.erb' is hard coded to '/etc/ssh/banner.txt'
Not all flavours use this. (for example, CentOS defaults to etc/issue.net)
I have made this configurable by adding an attribute.