Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of deprecated authorized_keys handling #143

Merged

Conversation

artem-sidorenko
Copy link
Member

@artem-sidorenko artem-sidorenko commented Dec 17, 2016

Resolves #16

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 82a2a29 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@artem-sidorenko artem-sidorenko changed the title Removal of deprecated authorized_keys handling WIP: Removal of deprecated authorized_keys handling Dec 17, 2016
@artem-sidorenko artem-sidorenko changed the title WIP: Removal of deprecated authorized_keys handling Removal of deprecated authorized_keys handling Dec 17, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f1445dc on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6775dbc on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4cac0c0 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 76bf9c5 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@atomic111
Copy link
Member

@artem-sidorenko thanks for cleaning this. May be you should add a hint in the README.md for the users. how to handle the ssh-key deployment. What do you think?

@artem-sidorenko
Copy link
Member Author

@atomic111 I added a short notice that user/key handling are out-of-scope. I do not want to recommend any solution for user/key management, as it completely depends on the environment and particular needs (e.g. some manage keys/users via chef/puppet, in other setups you will see LDAP or IPA or even AD)

@artem-sidorenko
Copy link
Member Author

@atomic111 and the deprecation notice was > 2 years old. In case somebody used it in the past - there was enough time to thing about alternatives :-)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a733ab2 on artem-sidorenko:remove-deprecated-authorited-keys into d1f1bf1 on dev-sec:master.

@atomic111 atomic111 self-requested a review December 19, 2016 12:01
@atomic111
Copy link
Member

great, thank you

@atomic111 atomic111 merged commit bfb15e5 into dev-sec:master Dec 19, 2016
@artem-sidorenko artem-sidorenko deleted the remove-deprecated-authorited-keys branch December 19, 2016 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants