CI, Harmonization of tests, Testing of Chef 13 and Chef 12 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Red tests of opensuse leap should be fixed by dev-sec/ssh-baseline#88 |
atomic111
reviewed
May 15, 2017
There was a problem hiding this comment.
@artem-sidorenko i am fine with this.
@chris-rock your opinion?
.kitchen.dokken.yml
Outdated
| - recipe[ssh-hardening] | ||
| verifier: | ||
| inspec_tests: | ||
| - https://github.com/dev-sec/tests-ssh-hardening |
There was a problem hiding this comment.
can you change the link to https://github.com/dev-sec/ssh-baseline
There was a problem hiding this comment.
good catch, thanks! :)
.kitchen.yml
Outdated
| @@ -78,3 +32,27 @@ suites: | |||
| verifier: | |||
| inspec_tests: | |||
| - https://github.com/dev-sec/tests-ssh-hardening | |||
There was a problem hiding this comment.
can you change the link to https://github.com/dev-sec/ssh-baseline
.kitchen.yml
Outdated
| use_pam: false | ||
| verifier: | ||
| inspec_tests: | ||
| - https://github.com/dev-sec/tests-ssh-hardening |
There was a problem hiding this comment.
can you change the link to https://github.com/dev-sec/ssh-baseline
- Using vagrant for kitchen tests per default - Using dokken in the CI - Same travis configuration structure - Switch the tests to the latest available chef version Signed-off-by: Artem Sidorenko <artem@posteo.de>
Signed-off-by: Artem Sidorenko <artem@posteo.de>
Signed-off-by: Artem Sidorenko <artem@posteo.de>
chris-rock
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@chris-rock @atomic111 I took a similar approach like in os-hardening,
.kitchen.ymlcontains now vagrant setup and some parameters,.kitchen.dokken.ymlcontains configs for dokken/docker.I had some problems with dokken: because of systemd thing, privileged container and some error the systemd of my host was influenced by the container process and broke. Since then I'm only using the vagrant way. I do not know your setups, but I hope this change is Okay. If not, let us discuss the alternatives
Fixes #174, #177