Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Extra Configuration #183

Merged
merged 1 commit into from
Nov 22, 2017
Merged

Conversation

bdwyertech
Copy link
Contributor

@bdwyertech bdwyertech commented Nov 6, 2017

Extra config block needs to come before the potential SFTP Match configuration. If SFTP is enabled, any extra configuration options fall under the match block and do not take effect.

The statement on this line is correct, Match blocks must always be at the end of the configuration file 😉 https://github.com/dev-sec/chef-ssh-hardening/blob/master/templates/default/opensshd.conf.erb#L227

Extra config needs to come before the potential SFTP Match configuration
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.822% when pulling d280303 on bdwyertech:patch-1 into b47c92e on dev-sec:master.

Copy link
Member

@artem-sidorenko artem-sidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bdwyertech many thanks for this fix!

@artem-sidorenko artem-sidorenko merged commit a6498da into dev-sec:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants