Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified the client_alive_interval default to 300 #187

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

iennae
Copy link
Contributor

@iennae iennae commented Feb 2, 2018

While this cookbook isn't specific (and shouldn't be specific) to CIS Benchmarks, it's helpful as a
baseline to set the default behaviors to the recommended value. Folks can override to 600 if needed.

…s benchmark.

While this cookbook isn't specific (and shouldn't be specific) to CIS Benchmarks, it's helpful as a
baseline to set the default behaviors to the recommended value. Folks can override to 600 if needed.

Signed-off-by: Jennifer Davis <iennae@gmail.com>
@coveralls
Copy link

coveralls commented Feb 2, 2018

Coverage Status

Coverage remained the same at 99.822% when pulling dd8039c on iennae:client_alive_interval into 6fea6c2 on dev-sec:master.

@artem-sidorenko
Copy link
Member

@iennae thanks for this PR, it looks good to me. Can I maybe ask you also to update the test in the baseline? https://github.com/dev-sec/ssh-baseline/blob/master/controls/sshd_spec.rb#L352-L359

Copy link
Member

@artem-sidorenko artem-sidorenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iennae thank you!

@artem-sidorenko artem-sidorenko merged commit 82f46a2 into dev-sec:master Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants