Remove deprecated options #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSH protocol 1 server support removed ------------------------------------- sshd(8) no longer supports the old SSH protocol 1, so all the configuration options related to it are now deprecated and should be removed from /etc/ssh/sshd_config. These are: KeyRegenerationInterval RSAAuthentication RhostsRSAAuthentication ServerKeyBits The Protocol option is also no longer needed, although it is silently ignored rather than deprecated. https://salsa.debian.org/ssh-team/openssh/commit/fb87db8aa47d3508be8e5bb1d21897fa1f2eca90
|
What is a better way to fix tests too? |
|
@kuzaxak thanks for this PR! Failing tests are located in the ssh-baseline, so we need another PR there. This change is effective for openssh >7.4, do I get this right? |
Closed
|
@artem-sidorenko yes, looks correct. the baseline failed because it searches for variables that don't exist anymore. But I think completely removing them is no good idea. There should be some backward compatibility for older systems. The test and also the cookbooks should check what OpenSSH version is used, and based on that they should set or not set that variables / check or not check that variables. |
|
I created a PR in the SSH baseline repo for this issue. This one could be merged, I guess, after that PR is accepted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSH protocol 1 server support removed
sshd(8) no longer supports the old SSH protocol 1, so all the configuration
options related to it are now deprecated and should be removed from
/etc/ssh/sshd_config. These are:
KeyRegenerationInterval
RSAAuthentication
RhostsRSAAuthentication
ServerKeyBits
The Protocol option is also no longer needed, although it is silently
ignored rather than deprecated.
https://salsa.debian.org/ssh-team/openssh/commit/fb87db8aa47d3508be8e5bb1d21897fa1f2eca90