Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify an alternate AuthorizedKeysFile inside the Match block #214

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

dud225
Copy link
Contributor

@dud225 dud225 commented Mar 20, 2019

Since OpenSSH OpenSSH 5.6 (2010-08-23), one can specify an AuthorizedKeysFile parameter inside the Match block.

I didn't add any test because I don't think rspec can handle multiple parameters (the global one & the Match one).

@coveralls
Copy link

coveralls commented Mar 20, 2019

Coverage Status

Coverage increased (+0.002%) to 99.843% when pulling 54dd2ce on dud225:auth_keys_file into bc6d53e on dev-sec:master.

@artem-sidorenko
Copy link
Member

@dud225 thanks for this PR and sorry for delay. It looks good to me, can you please rebase it on the latest master and fix the spec tests?

@dud225 dud225 force-pushed the auth_keys_file branch 3 times, most recently from dc03954 to 7233cd1 Compare July 18, 2019 07:19
@artem-sidorenko
Copy link
Member

@dud225 can you please make the spec tests green? I guess only a minor adjustment regarding the spaces is required...

Signed-off-by: Hervé Werner <herve.werner@ledger.fr>
@dud225
Copy link
Contributor Author

dud225 commented Jul 18, 2019

I've fixed the tests

@artem-sidorenko
Copy link
Member

@dud225 many thanks!

@artem-sidorenko artem-sidorenko merged commit f0644d4 into dev-sec:master Jul 18, 2019
@artem-sidorenko
Copy link
Member

@dud225 is this change urgent for you or can it wait till next bigger release?

@dud225
Copy link
Contributor Author

dud225 commented Jul 19, 2019

@artem-sidorenko
No worries I can wait for the next release.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants