Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chef Spec Tests #39

Merged
merged 6 commits into from
Oct 11, 2014
Merged

Chef Spec Tests #39

merged 6 commits into from
Oct 11, 2014

Conversation

chris-rock
Copy link
Member

  • makes chef spec default for tests
  • add basic tests for server and client
  • bugfix permission settings

arlimus
arlimus reviewed Sep 29, 2014
View reviewed changes
spec/recipes/default_spec.rb
ChefSpec::Runner.new.converge(described_recipe)
end

# check that the recipres are executed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tiny typo: recipes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks for finding this....

@bkw bkw mentioned this pull request Oct 11, 2014
Merged
@arlimus
Copy link
Member

arlimus commented Oct 11, 2014

Great stuff, thank you! 👍

@arlimus
Copy link
Member

arlimus commented Oct 11, 2014

Could you please rebase? Cheers

@chris-rock
update gem file and integrate chef spec 4
d45516c 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
make chef spec tests a default task
09c863e 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
add chef server to spec helper and integrate coverage report
4460a3f 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
bugfix permission setting and add spec test
85d8a4a 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
bugfix permission setting and add spec test for server recipe
e318747 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
@chris-rock
fix typo
1e50b90
@chris-rock
Copy link
Member Author

@arlimus is rebased, @bkw please rebase #43 after this has been merged

@bkw
Copy link
Contributor

bkw commented Oct 11, 2014

Is rebasing really worth the hassle - given that both PRs work on the same files and for the same purpose?
I'd rather backport your improvements to the rakefile and the permission thingy into mine. I would cherry-pick where possible.

@arlimus
Copy link
Member

arlimus commented Oct 11, 2014

Github didn't let me merge without rebase, sorry about that.
@chris-rock Thanks!

arlimus added a commit that referenced this pull request Oct 11, 2014
@arlimus
Merge pull request #39 from TelekomLabs/chef-spec
3799c25 
Chef Spec Tests
@arlimus arlimus merged commit 3799c25 into master Oct 11, 2014
@arlimus arlimus deleted the chef-spec branch October 11, 2014 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-rock @arlimus @bkw