Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to chefspec 4.1.1 #45

Merged
merged 7 commits into from
Oct 13, 2014
Merged

update to chefspec 4.1.1 #45

merged 7 commits into from
Oct 13, 2014

Conversation

bkw
Copy link
Contributor

@bkw bkw commented Oct 13, 2014

syntax updated to use the new chefspec-4.1.0 way of doing things, no functional changes.

  • update chefspec and chef dependencies (chefspec-4.1.0 needs at least chef 11.14)
  • remove deprecated explicit require of chefspec/server
  • change ChefSpec::Runner into ChefSpec::ServerRunner
  • construct data bags inside of chef_run block

For details, see https://github.com/sethvargo/chefspec/blob/master/CHANGELOG.md

@bkw
Copy link
Contributor Author

bkw commented Oct 13, 2014

rebased for current master

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.08%) when pulling 2897394 on bkw:chefspec-4.1.0 into 7ab4273 on TelekomLabs:master.

@bkw
Copy link
Contributor Author

bkw commented Oct 13, 2014

seems coveralls and chefspec-4.1.0 don't play nicely together just yet. Bummer.

@bkw
Copy link
Contributor Author

bkw commented Oct 13, 2014

I created chefspec/chefspec#504 for this, in case it really is a chefspec issue.

@bkw bkw added the invalid label Oct 13, 2014
@bkw bkw removed the invalid label Oct 13, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 3922d31 on bkw:chefspec-4.1.0 into 7ab4273 on TelekomLabs:master.

@bkw bkw changed the title update to chefspec 4.1.0 update to chefspec 4.1.1 Oct 13, 2014
@bkw
Copy link
Contributor Author

bkw commented Oct 13, 2014

Thanks to @sethvargo himself, this thing can now be merged. Yay!

@chris-rock
Copy link
Member

that is amazing @bkw

chris-rock added a commit that referenced this pull request Oct 13, 2014
@chris-rock
Merge pull request #45 from bkw/chefspec-4.1.0
54ff658 
update to chefspec 4.1.1
@chris-rock chris-rock merged commit 54ff658 into dev-sec:master Oct 13, 2014
@bkw
Copy link
Contributor Author

bkw commented Oct 13, 2014

Thanks for merging! <3

@bkw bkw deleted the chefspec-4.1.0 branch October 14, 2014 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bkw @coveralls @chris-rock