-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub action #103
GitHub action #103
Conversation
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
Signed-off-by: Sebastian Gumprich <sebastian.gumprich@t-systems.com>
We changed the travis tests with github actions. There was only some internal discussion. We plan to fix the tests, too. Why do you think this is a breaking change? The code itself did not change. |
my rationale for merging this was, that it may be not a great idea to change the complete CI workflow and do a lot of syntactic code changes in one PR. We are already working on fixng the lint recommendations. :) |
Prior to this change the convention seemed to be that all the Checks must pass (DCO and Travis). Now that travis has been removed, there are 3 failing Checks now for the most current release: https://github.com/dev-sec/cis-dil-benchmark/actions/runs/511972343 which i believe are caused by the .rubocop.yml changes, some of which were allowed in order to align with the Inspec Style Guide recommendations
@schurzi , what will be the expected workflow for accepting PRs in the interim? |
This is not a breaking change according to semantic versioning. For the baseline itself this is not a change at all since we didn't change any of the code. |
Valid point, my concern was more with how future PRs will be handled. Previously the convention was that both the DCO and Lint checks must pass before the PR was approved/merged. Would it be possible to revert the rubocop changes until the syntax updates described previously are ready so as not to cause failures in PRs in the mean time? |
Yeah, you're right. This wasn't the best move, sorry. I'll fix this tomorrow. Either by fixing the linting or reverting. |
@rndmh3ro thanks! also very excited to see more use of GitHub Actions! |
No description provided.