cis-dil-benchmark-5.3.4 should match spaces better #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5.3.3 uses this matching logic and it works, password [success=1 default=ignore] pam_unix.so obscure use_authtok try_first_pass sha512 remember=5 is matched by 5.3.3 regular expression, but didn't match 5.3.4 because of a space between "1" and "default" Signed-off-by: Peter Turner <pturner@uwalumni.com>
|
nice catch, thank you! I transferred your sign-off from the Github message to your commit, so we have a clean history in git. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
5.3.3 uses this matching logic and it works,
password [success=1 default=ignore] pam_unix.so obscure use_authtok try_first_pass sha512 remember=5
is matched by 5.3.3 regular expression, but didn't match 5.3.4 because of a space between "1" and "default"
Signed-off-by: Peter Turner pturner@uwalumni.com