Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIS4.1.5 fix 64 bit support #131

Closed
wants to merge 1 commit into from

Conversation

spencer-cdw
Copy link
Contributor

This fixes the logic so that 32 bit checks only run on 32 bit sytems and 64 bit checks run on 64 bit systems.

Before this change, the 32 bit check would always run, even on 64 bit systems and would give false failures.

Screen Shot 2022-11-01 at 9 14 22 PM
Screen Shot 2022-11-01 at 9 15 28 PM

Note: I'm not sure how to test this on non x86 systems. Any guidance about how to raise a failure appreciated.

OSX:

uname -m
arm64

Ubuntu

uname -m
aarch64

Signed-off-by: Spencer Owen <spencer.owen@cdw.com>
@spencer-cdw
Copy link
Contributor Author

This actually might be intentional.
According to this stack overflow question you may want both 32 and 64 bit checks on 64 bit systems incase you use any 32 bit libraries.

@spencer-cdw
Copy link
Contributor Author

Confirmed, on 64 bit systems, both arch=b32 and arch=b64 should be set.

Screen Shot 2022-11-01 at 10 32 30 PM
Screen Shot 2022-11-01 at 10 31 52 PM

@spencer-cdw spencer-cdw closed this Nov 2, 2022
@schurzi
Copy link
Contributor

schurzi commented Nov 2, 2022

This actually might be intentional. According to this stack overflow question you may want both 32 and 64 bit checks on 64 bit systems incase you use any 32 bit libraries.

Yes, exactly this! Do you want to add a comment with this information so nobody else has to discover this? ;)

@spencer-cdw
Copy link
Contributor Author

Yes, documented here: #132

@spencer-cdw spencer-cdw deleted the 64bit_audit_rules branch November 14, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants