Debian uses group 42 shadow #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-rock
requested changes
Jun 5, 2018
There was a problem hiding this comment.
Thank you @timstoop for highlighting and fixing this issue. Your solution will work, I have a small nitpick on the style though. I prefer if tests keep as readable as possible
| its(:sticky) { should equal false } | ||
| its(:suid) { should equal false } | ||
| its(:sgid) { should equal false } | ||
| end | ||
| if os.debian? |
There was a problem hiding this comment.
I think we can make the test more readable if we do the following instead:
expected_gid = 0
expected_gid = 42 if os.debian?
shadow_files.each do |f|
describe file(f) do
...
its(:gid) { should cmp expected_gid }
There was a problem hiding this comment.
Honestly, I'm not very good at Ruby (I'm more a Python guy), so any advice here is appreciated! I'll make the change and push it.
HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop)
chris-rock
approved these changes
Jun 6, 2018
michael-c-hoffman
pushed a commit
to michael-c-hoffman/cis-dil-benchmark
that referenced
this pull request
Jun 13, 2018
* Each MAC entry should be an element in the list. * Check if each MAC is approved instead of specific sets of MACs. * Trying to get syntax right to iterate over array. * Ensuring the MACs list is proper. * Fixing linting error. * Fix checking of password quality items. * Trying to get the check right. * Try using whether a package is installed as the identifier. * pwquality requires a different package on amazon and centos7. * Adding a whole section for cracklib checks also. * Missing an end to a describe. * Working on regex check for password quality. * Got the regex right. * More work on the password options regex. * Fixed regex for cracklib adding back in if statement for package. * Fix linting issues, added an inline ignore to large block length for this control. * Add just a bashrc file for Centos7 and check for file existence before checking for values in it. * Fix file existence syntax. * Wrap block in if statement. * Fix style issues for rubocop. * Remove ruby-version from commit. * Remove Gemfile.lock. * Adjust modprobe check to remove false positives. * updated regex to account for sha512 not being first option * Fix deprecation warnings. (dev-sec#34) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Change regex to allow multiple spaces. (dev-sec#35) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Debian uses group 42, which is just as secure. (dev-sec#33) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * ubuntu modinfo
michael-c-hoffman
pushed a commit
to michael-c-hoffman/cis-dil-benchmark
that referenced
this pull request
Jun 13, 2018
* Each MAC entry should be an element in the list. * Check if each MAC is approved instead of specific sets of MACs. * Trying to get syntax right to iterate over array. * Ensuring the MACs list is proper. * Fixing linting error. * Fix checking of password quality items. * Trying to get the check right. * Try using whether a package is installed as the identifier. * pwquality requires a different package on amazon and centos7. * Adding a whole section for cracklib checks also. * Missing an end to a describe. * Working on regex check for password quality. * Got the regex right. * More work on the password options regex. * Fixed regex for cracklib adding back in if statement for package. * Fix linting issues, added an inline ignore to large block length for this control. * Add just a bashrc file for Centos7 and check for file existence before checking for values in it. * Fix file existence syntax. * Wrap block in if statement. * Fix style issues for rubocop. * Remove ruby-version from commit. * Remove Gemfile.lock. * Adjust modprobe check to remove false positives. * updated regex to account for sha512 not being first option * Fix deprecation warnings. (dev-sec#34) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Change regex to allow multiple spaces. (dev-sec#35) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Debian uses group 42, which is just as secure. (dev-sec#33) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * ubuntu modinfo * update
michael-c-hoffman
pushed a commit
to michael-c-hoffman/cis-dil-benchmark
that referenced
this pull request
Jun 13, 2018
* Each MAC entry should be an element in the list. * Check if each MAC is approved instead of specific sets of MACs. * Trying to get syntax right to iterate over array. * Ensuring the MACs list is proper. * Fixing linting error. * Fix checking of password quality items. * Trying to get the check right. * Try using whether a package is installed as the identifier. * pwquality requires a different package on amazon and centos7. * Adding a whole section for cracklib checks also. * Missing an end to a describe. * Working on regex check for password quality. * Got the regex right. * More work on the password options regex. * Fixed regex for cracklib adding back in if statement for package. * Fix linting issues, added an inline ignore to large block length for this control. * Add just a bashrc file for Centos7 and check for file existence before checking for values in it. * Fix file existence syntax. * Wrap block in if statement. * Fix style issues for rubocop. * Remove ruby-version from commit. * Remove Gemfile.lock. * Adjust modprobe check to remove false positives. * updated regex to account for sha512 not being first option * Fix deprecation warnings. (dev-sec#34) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Change regex to allow multiple spaces. (dev-sec#35) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Debian uses group 42, which is just as secure. (dev-sec#33) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * ubuntu modinfo * update * update
michael-c-hoffman
pushed a commit
to michael-c-hoffman/cis-dil-benchmark
that referenced
this pull request
Jun 13, 2018
* Each MAC entry should be an element in the list. * Check if each MAC is approved instead of specific sets of MACs. * Trying to get syntax right to iterate over array. * Ensuring the MACs list is proper. * Fixing linting error. * Fix checking of password quality items. * Trying to get the check right. * Try using whether a package is installed as the identifier. * pwquality requires a different package on amazon and centos7. * Adding a whole section for cracklib checks also. * Missing an end to a describe. * Working on regex check for password quality. * Got the regex right. * More work on the password options regex. * Fixed regex for cracklib adding back in if statement for package. * Fix linting issues, added an inline ignore to large block length for this control. * Add just a bashrc file for Centos7 and check for file existence before checking for values in it. * Fix file existence syntax. * Wrap block in if statement. * Fix style issues for rubocop. * Remove ruby-version from commit. * Remove Gemfile.lock. * Adjust modprobe check to remove false positives. * updated regex to account for sha512 not being first option * Fix deprecation warnings. (dev-sec#34) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Change regex to allow multiple spaces. (dev-sec#35) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Debian uses group 42, which is just as secure. (dev-sec#33) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * ubuntu modinfo * update * update * update
michael-c-hoffman
pushed a commit
to michael-c-hoffman/cis-dil-benchmark
that referenced
this pull request
Jun 13, 2018
* Each MAC entry should be an element in the list. * Check if each MAC is approved instead of specific sets of MACs. * Trying to get syntax right to iterate over array. * Ensuring the MACs list is proper. * Fixing linting error. * Fix checking of password quality items. * Trying to get the check right. * Try using whether a package is installed as the identifier. * pwquality requires a different package on amazon and centos7. * Adding a whole section for cracklib checks also. * Missing an end to a describe. * Working on regex check for password quality. * Got the regex right. * More work on the password options regex. * Fixed regex for cracklib adding back in if statement for package. * Fix linting issues, added an inline ignore to large block length for this control. * Add just a bashrc file for Centos7 and check for file existence before checking for values in it. * Fix file existence syntax. * Wrap block in if statement. * Fix style issues for rubocop. * Remove ruby-version from commit. * Remove Gemfile.lock. * Adjust modprobe check to remove false positives. * updated regex to account for sha512 not being first option * Fix deprecation warnings. (dev-sec#34) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Change regex to allow multiple spaces. (dev-sec#35) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * Debian uses group 42, which is just as secure. (dev-sec#33) HardeningFramework-DCO-1.1-Signed-off-by: Tim Stoop <github@timstoop.nl> (github: timstoop) * ubuntu modinfo * update * update * update * ubuntu update
deric4
pushed a commit
to Logicworks/cis-dil-benchmark
that referenced
this pull request
Jan 5, 2021
* refactor `attribute()` -> `input()` * fix regression/add supportfor evaluating gid on /etc/shadow and friends on - debian - suse - alpine Ref: - dev-sec#33 - dev-sec/linux-baseline#70 on-behalf-of: @Logicworks <dmiguel@logicworks.net> Signed-off-by: Deric Miguel <dmiguel@logicworks.net>
deric4
pushed a commit
to Logicworks/cis-dil-benchmark
that referenced
this pull request
Jan 7, 2021
* refactor `attribute()` -> `input()` * fix regression/add supportfor evaluating gid on /etc/shadow and friends on - debian - suse - alpine Ref: - dev-sec#33 - dev-sec/linux-baseline#70 on-behalf-of: @Logicworks <dmiguel@logicworks.net> Signed-off-by: Deric Miguel <dmiguel@logicworks.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31 (this time actually tested...)