use inspec's new unified attributes feature #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpop
approved these changes
Oct 4, 2018
| end | ||
| end | ||
| end | ||
| only_if { } |
There was a problem hiding this comment.
Great catch @alexpop Fixing it now
chris-rock
force-pushed
the
chris-rock/inspec-global-attributes
branch
from
e23acb2
to
9930e72
Compare
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
chris-rock
force-pushed
the
chris-rock/inspec-global-attributes
branch
from
0b1fe32
to
8f46c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR optimizes the profile to define the attribute just once. It is using InSpec's new unified attribute feature inspec/inspec#3176
It also updates the profile to follow InSpec's style guide https://www.inspec.io/docs/reference/style/ where if conditions around controls are discouraged
Signed-off-by: Christoph Hartmann chris@lollyrock.com