Refactor out grub config to profile file #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdchurchill
force-pushed
the
grub-location-refactor
branch
from
57335eb
to
d85bcb4
Compare
chris-rock
requested changes
Apr 1, 2020
markdchurchill
force-pushed
the
grub-location-refactor
branch
3 times, most recently
from
b2da0ed
to
69ec3e7
Compare
|
@chris-rock those minor whitespace issues are fixed on the #77 pr. not sure how they got into master 🤷♂️ |
|
@markdchurchill Can you rebase on latest master? |
chris-rock
reviewed
Apr 6, 2020
| class GrubConf < Inspec.resource(1) | ||
| name 'grub_conf' | ||
|
|
||
| def locations |
There was a problem hiding this comment.
🎉 Thank you for moving the config to the resource!
Signed-off-by: Mark Churchill <markdchurchill@outlook.com>
markdchurchill
force-pushed
the
grub-location-refactor
branch
from
69ec3e7
to
2a917dc
Compare
Ooops, I mean done here. |
chris-rock
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #17, #74, etc.
This pulls the canonical locations for the grub.cfg file into one spot so we aren't chasing our tail in multiple controls. Not sure if the pattern is appropriate, I'm not an ops/inspec guy.