Properly verify the kernel dump setting #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0 and 2 are the allowed options
chris-rock
approved these changes
Mar 13, 2017
|
@chris-rock I fixed the second dump test here, can you please have a look? |
artem-sidorenko
force-pushed
the
kernel-dump
branch
from
0677c2d to
8f586ca
Compare
chris-rock
approved these changes
Mar 13, 2017
There was a problem hiding this comment.
This looks like a very good solution to me @artem-sidorenko I would like to have @atomic111 review it as well, just to be sure I have not missed anything. LGTM after the end is fixed
controls/sysctl_spec.rb
Outdated
| impact 1.0 | ||
| title 'Secure Core Dumps - dump path' | ||
| desc 'Ensure that core dumps are done with fully qualified path' | ||
| only_if { kernel_parameter('fs.suid_dumpable').value == 2 } | ||
| end |
artem-sidorenko
force-pushed
the
kernel-dump
branch
from
8f586ca to
e3df2db
Compare
atomic111
approved these changes
Mar 16, 2017
There was a problem hiding this comment.
@artem-sidorenko thanks for the improvement. if someone wants to have more information http://man7.org/linux/man-pages/man5/core.5.html
artem-sidorenko
added a commit
to artem-forks/chef-os-hardening
that referenced
this pull request
Mar 28, 2017
See dev-sec/linux-baseline#52 for more details
artem-sidorenko
added a commit
to artem-forks/chef-os-hardening
that referenced
this pull request
Mar 28, 2017
See dev-sec/linux-baseline#52 for more details
artem-sidorenko
added a commit
to artem-forks/chef-os-hardening
that referenced
this pull request
Mar 28, 2017
See dev-sec/linux-baseline#52 for more details
artem-sidorenko
added a commit
to artem-forks/chef-os-hardening
that referenced
this pull request
Mar 29, 2017
See dev-sec/linux-baseline#52 for more details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0 and 2 are the allowed options