Fix os detection #120
Merged
Fix os detection #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit the regex searched for the pattern
anywhere in the string. This resulted in the following on Centos 7.6:
(The `string centos release:` was added as a debug output)
```
basti$ bundle exec inspec exec ../ssh-baseline/ -t docker://79335b76fbaf --controls=ssh-08
"centos release: 7.6.1810"
"centos release: 7.6.1810"
Profile: DevSec SSH Baseline (ssh-baseline)
Version: 2.3.2
Target: docker://79335b76fbaf7cf6877bd4b86f220cde2dba595baeb96ec6feb5ede279c17bc1
× ssh-08: Client: Check for secure ssh ciphers
× SSH Configuration Ciphers should eq "aes256-ctr,aes192-ctr,aes128-ctr"
expected: "aes256-ctr,aes192-ctr,aes128-ctr"
got: "chacha20-poly1305@openssh.com,aes256-gcm@openssh.com,aes128-gcm@openssh.com,aes256-ctr,aes192-ctr,aes128-ctr"
(compared using ==)
Profile Summary: 0 successful controls, 1 control failure, 0 controls skipped
Test Summary: 0 successful, 1 failure, 0 skipped
```
For the version string `7.6.1810` the case-statement in the library found `6\.`
and since this is the first case statement, ciphers will get set to ciphers53.
This commit changes the behaviour to look for the pattern at the beginning of the line.
Open question:
Are all version-strings just the number without anything before or after it? I could not check for MacOS,
so I changed the regex only for the OS I knew.
Signed-off-by: Sebastian Gumprich <github@gumpri.ch>
…r all OS Signed-off-by: IceBear2k <ib-github@myrl.net>
chris-rock
approved these changes
Jan 13, 2019
There was a problem hiding this comment.
This is a great improvement @IceBear2k Thank you @rndmh3ro for identifying the root cause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes #119 plus additional fixes for all other OS version detection.