Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic support for Ubuntu 22 #204

Merged
merged 2 commits into from
Aug 6, 2022
Merged

add basic support for Ubuntu 22 #204

merged 2 commits into from
Aug 6, 2022

Conversation

schurzi
Copy link
Contributor

@schurzi schurzi commented Aug 4, 2022

This adds basic support for Ubuntu 22. I have not checked if there are newer (better) supported ciphers. I assume, the slightly older ones are still ok for a first update. Currently this control fails on Ubuntu 22 after hardening with our Ansible Collection is applied.

Signed-off-by: Martin Schurz Martin.Schurz@t-systems.com

Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Signed-off-by: Martin Schurz <Martin.Schurz@t-systems.com>
Copy link
Member

@micheelengronne micheelengronne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it seems correct.

@rndmh3ro
Copy link
Member

rndmh3ro commented Aug 4, 2022

I just checked the differences for defaults MACs, Kex and Ciphers between Ubuntu 18, 20 and 22.

We should probably add some new variables for the different ssh-versions, add the defaults and then substracts known weak ciphers (if needed). @schurzi what do you think?

ssh-versions:
18: 7.6
20: 8.2
22: 8.9

22
umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1

20
umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1

18
umac-64-etm@openssh.com,umac-128-etm@openssh.com,hmac-sha2-256-etm@openssh.com,hmac-sha2-512-etm@openssh.com,hmac-sha1-etm@openssh.com,umac-64@openssh.com,umac-128@openssh.com,hmac-sha2-256,hmac-sha2-512,hmac-sha1


22
curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,sntrup761x25519-sha512@openssh.com,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256

20
curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group16-sha512,diffie-hellman-group18-sha512,diffie-hellman-group14-sha256


18
curve25519-sha256,curve25519-sha256@libssh.org,ecdh-sha2-nistp256,ecdh-sha2-nistp384,ecdh-sha2-nistp521,diffie-hellman-group-exchange-sha256,diffie-hellman-group14-sha1


22
chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm@openssh.com,aes256-gcm@openssh.com

20
chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm@openssh.com,aes256-gcm@openssh.com

18
chacha20-poly1305@openssh.com,aes128-ctr,aes192-ctr,aes256-ctr,aes128-gcm@openssh.com,aes256-gcm@openssh.com

@schurzi
Copy link
Contributor Author

schurzi commented Aug 6, 2022

Thanks for compiling the lists @rndmh3ro. I have checked them with our Ansible Collection, a Test VM and at CIS Benchmark. If I account for insecure settings, almost all lists are identical.

We currently do our checks based on some specific key versions of OpenSSH, every time there is a substantial new algorithm we want to support we create a new variable and extend our logic in the library. Currently I do not see the need to introduce a new variable for 8.9, the settings from 8.5 still seem applicable.

Regarding your thoughts, I think I am in favor of rewriting our checks to a version based approach. I also think I want to reverse the function logic. But I kind of want to handle this in a separate Issue/PR.

@schurzi
Copy link
Contributor Author

schurzi commented Aug 6, 2022

opened new issue #205 for that

@schurzi schurzi merged commit b809e0b into master Aug 6, 2022
@schurzi schurzi deleted the ubuntu22 branch August 6, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants