Descriptive spec #39
Merged
Descriptive spec #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the current version of tests and a spec fails, we get an output similar to this:
2) check sshd_config File "/etc/ssh/sshd_config" content should valid cipher
Failure/Error: should valid_cipher
expected "..." to valid cipher
This is not very helpful, since it doesn't tell us what it really expects (e.g. a list of valid ciphers). Best case scenario: you only have to look into the spec file, worst case: your spec has some other error (like OS-detection) and it starts to get really confusing.
This implementation fixes this issue. It is not as elegant as the current one, but prints very descriptive errors:
2) check ssh_config File "/etc/ssh/ssh_config" content should match /^Ciphers aes256-ctr,aes192-ctr,aes128-ctr$/
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
Signed-off-by: Dominik Richter <dominik.richter@gmail.com>
|
from a user point of view an improvement. I value feedback over elegance |
|
great, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the current version of tests for our crypto algos and a spec fails, we get an output similar to this:
This is not very helpful, since it doesn't tell us what it really expects (e.g. a list of valid ciphers). Best case scenario: you only have to look into the spec file, worst case: your spec has some other error (like OS-detection) and it starts to get really messy.
This implementation fixes this issue. It is not as elegant as the current one, but prints very descriptive errors: