[Snyk] Upgrade esbuild from 0.14.48 to 0.15.10 #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to upgrade esbuild from 0.14.48 to 0.15.10.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
Release notes
Package name: esbuild
Add support for node's "pattern trailers" syntax (#2569)
After esbuild implemented node's
exports
feature inpackage.json
, node changed the feature to also allow text after*
wildcards in patterns. Previously the*
was required to be at the end of the pattern. It lets you do something like this:With this release, esbuild now supports these types of patterns too.
Fix subpath imports with Yarn PnP (#2545)
Node has a little-used feature called subpath imports which are package-internal imports that start with
#
and that go through theimports
map inpackage.json
. Previously esbuild had a bug that caused esbuild to not handle these correctly in packages installed via Yarn's "Plug'n'Play" installation strategy. The problem was that subpath imports were being checked after Yarn PnP instead of before. This release reorders these checks, which should allow subpath imports to work in this case.Link from JS to CSS in the metafile (#1861, #2565)
When you import CSS into a bundled JS file, esbuild creates a parallel CSS bundle next to your JS bundle. So if
app.ts
imports some CSS files and you bundle it, esbuild will give youapp.js
andapp.css
. You would then add both<script src="app.js"></script>
and<link href="app.css" rel="stylesheet">
to your HTML to include everything in the page. This approach is more efficient than having esbuild insert additional JavaScript intoapp.js
that downloads and includesapp.css
because it means the browser can download and parse both the CSS and the JS in parallel (and potentially apply the CSS before the JS has even finished downloading).However, sometimes it's difficult to generate the
<link>
tag. One case is when you've added[hash]
to the entry names setting to include a content hash in the file name. Then the file name will look something likeapp-GX7G2SBE.css
and may change across subsequent builds. You can tell esbuild to generate build metadata using themetafile
API option but the metadata only tells you which generated JS bundle corresponds to a JS entry point (via theentryPoint
property), not which file corresponds to the associated CSS bundle. Working around this was hacky and involved string manipulation.This release adds the
cssBundle
property to the metafile to make this easier. It's present on the metadata for the generated JS bundle and points to the associated CSS bundle. So to generate the HTML tags for a given JS entry point, you first find the output file with theentryPoint
you are looking for (and put that in a<script>
tag), then check for thecssBundle
property to find the associated CSS bundle (and put that in a<link>
tag).One thing to note is that there is deliberately no
jsBundle
property mapping the other way because it's not a 1:1 relationship. Two JS bundles can share the same CSS bundle in the case where the associated CSS bundles have the same name and content. In that case there would be no one value for a hypotheticaljsBundle
property to have.Fix an obscure npm package installation issue with
--omit=optional
(#2558)The previous release introduced a regression with
npm install esbuild --omit=optional
where the filenode_modules/.bin/esbuild
would no longer be present after installation. That could cause any package scripts which used theesbuild
command to no longer work. This release fixes the regression sonode_modules/.bin/esbuild
should now be present again after installation. This regression only affected people installing esbuild usingnpm
with either the--omit=optional
or--no-optional
flag, which is a somewhat unusual situation.More details:
The reason for this regression is due to some obscure npm implementation details. Since the Go compiler doesn't support trivial cross-compiling on certain Android platforms, esbuild's installer installs a WebAssembly shim on those platforms instead. In the previous release I attempted to simplify esbuild's WebAssembly shims to depend on the
esbuild-wasm
package instead of including another whole copy of the WebAssembly binary (to make publishing faster and to save on file system space after installation). However, both theesbuild
package and theesbuild-wasm
package provide a binary calledesbuild
and it turns out that addingesbuild-wasm
as a nested dependency of theesbuild
package (specificallyesbuild
optionally depends on@ esbuild/android-arm
which depends onesbuild-wasm
) caused npm to be confused about whatnode_modules/.bin/esbuild
is supposed to be.It's pretty strange and unexpected that disabling the installation of optional dependencies altogether would suddenly cause an optional dependency's dependency to conflict with the top-level package. What happens under the hood is that if
--omit=optional
is present, npm attempts to uninstall theesbuild-wasm
nested dependency at the end ofnpm install
(even though theesbuild-wasm
package was never installed due to--omit=optional
). This uninstallation causesnode_modules/.bin/esbuild
to be deleted.After doing a full investigation, I discovered that npm's handling of the
.bin
directory is deliberately very brittle. When multiple packages in the dependency tree put something in.bin
with the same name, the end result is non-deterministic/random. What you get in.bin
might be from one package, from the other package, or might be missing entirely. The workaround suggested by npm is to just avoid having two packages that put something in.bin
with the same name. So this was fixed by making the@ esbuild/android-arm
andesbuild-android-64
packages each include another whole copy of the WebAssembly binary, which works because these packages don't put anything in.bin
.Fix JSX name collision edge case (#2534)
Code generated by esbuild could have a name collision in the following edge case:
automatic
, which causesimport
statements to be inserted{...spread}
followed by akey={...}
, which uses the legacycreateElement
fallback imported fromreact
react
such as@ remix-run/react
import
statements are converted into require callsIn this case, esbuild previously generated two variables with the same name
import_react
, like this:That bug is fixed in this release. The code generated by esbuild no longer contains a name collision.
Fall back to WebAssembly on Android ARM (#1556, #1578, #2335, #2526)
Go's compiler supports trivial cross-compiling to almost all platforms without installing any additional software other than the Go compiler itself. This has made it very easy for esbuild to publish native binary executables for many platforms. However, it strangely doesn't support cross-compiling to Android ARM without installing the Android build tools.
So instead of publishing a native esbuild binary executable to npm, this release publishes a WebAssembly fallback build. This is essentially the same as the
esbuild-wasm
package but it's installed automatically when you install theesbuild
package on Android ARM. So packages that depend on theesbuild
package should now work on Android ARM. This change has not yet been tested end-to-end because I don't have a 32-bit Android ARM device myself, but in theory it should work.This inherits the drawbacks of WebAssembly including significantly slower performance than native as well as potentially also more severe memory usage limitations and lack of certain features (e.g.
--serve
). If you want to use a native binary executable of esbuild on Android ARM, you may be able to build it yourself from source after installing the Android build tools.Attempt to better support Yarn's
ignorePatternData
feature (#2495)Part of resolving paths in a project using Yarn's Plug'n'Play feature involves evaluating a regular expression in the
ignorePatternData
property of.pnp.data.json
. However, it turns out that the particular regular expressions generated by Yarn use some syntax that works with JavaScript regular expressions but that does not work with Go regular expressions.In this release, esbuild will now strip some of the the problematic syntax from the regular expression before compiling it, which should hopefully allow it to be compiled by Go's regular expression engine. The specific character sequences that esbuild currently strips are as follows:
(?!\.)
(?!(?:^|\/)\.)
(?!\.{1,2}(?:\/|$))
(?!(?:^|\/)\.{1,2}(?:\/|$))
These seem to be used by Yarn to avoid the
.
and..
path segments in the middle of relative paths. The removal of these character sequences seems relatively harmless in this case since esbuild shouldn't ever generate such path segments. This change should add support to esbuild for Yarn'spnpIgnorePatterns
feature.Fix non-determinism issue with legacy block-level function declarations and strict mode (#2537)
When function declaration statements are nested inside a block in strict mode, they are supposed to only be available within that block's scope. But in "sloppy mode" (which is what non-strict mode is commonly called), they are supposed to be available within the whole function's scope:
function test1() {
'use strict'
function fn() { return 1 }
if (true) { function fn() { return 2 } }
return fn()
}
// This returns 2 due to sloppy mode
function test2() {
function fn() { return 1 }
if (true) { function fn() { return 2 } }
return fn()
}
To implement this, esbuild compiles these two functions differently to reflect their different semantics:
However, the compilation had a subtle bug where the automatically-generated function-level symbols for multible hoisted block-level function declarations in the same block a sloppy-mode context were generated in a random order if the output was in strict mode, which could be the case if TypeScript's
alwaysStrict
setting was set to true. This lead to non-determinism in the output as the minifier would randomly exchange the generated names for these symbols on different runs. This bug has been fixed by sorting the keys of the unordered map before iterating over them.Fix parsing of
@ keyframes
with string identifiers (#2555)Firefox supports
@ keyframes
with string identifier names. Previously this was treated as a syntax error by esbuild as it doesn't work in any other browser. The specification allows for this however, so it's technically not a syntax error (even though it would be unwise to use this feature at the moment). There was also a bug where esbuild would remove the identifier name in this case as the syntax wasn't recognized.This release changes esbuild's parsing of
@ keyframes
to now consider this case to be an unrecognized CSS rule. That means it will be passed through unmodified (so you can now use esbuild to bundle this Firefox-specific CSS) but the CSS will not be pretty-printed or minified. I don't think it makes sense for esbuild to have special code to handle this Firefox-specific syntax at this time. This decision can be revisited in the future if other browsers add support for this feature.Add the
--jsx-side-effects
API option (#2539, #2546)By default esbuild assumes that JSX expressions are side-effect free, which means they are annoated with
/* @ __PURE__ */
comments and are removed during bundling when they are unused. This follows the common use of JSX for virtual DOM and applies to the vast majority of JSX libraries. However, some people have written JSX libraries that don't have this property. JSX expressions can have arbitrary side effects and can't be removed. If you are using such a library, you can now pass--jsx-side-effects
to tell esbuild that JSX expressions have side effects so it won't remove them when they are unused.This feature was contributed by @ rtsao.
Read more
Read more
Fix issues with Yarn PnP and Yarn's workspaces feature (#2476)
This release makes sure esbuild works with a Yarn feature called workspaces. Previously esbuild wasn't tested in this scenario, but this scenario now has test coverage. Getting this to work involved further tweaks to esbuild's custom code for what happens after Yarn PnP's path resolution algorithm runs, which is not currently covered by Yarn's PnP specification. These tweaks also fix
exports
map resolution with Yarn PnP for non-empty subpaths, which wasn't previously working.Read more
Read more
Read more
Read more
Commit messages
Package name: esbuild
range
for all integral types rust-lang/rust#2557: remove warning about top-level `this`Compare
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs