Set maxBodyLength to 100MB to allow larger feature uploads #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if you have a better suggestion than |
joshspicer
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-redirectsnpm doc states that it's a drop-in replacement for the native http and https modules, but it turns out that's not quite true as it additionally sets a maximum HTTP request body length of 10MB by default. I expect this is because the request body is cached internally so it can be replayed, so is done in order to manage memory usage.This overrides the default maxBodySize to 100MB as a quick fix to allow larger devcontainer features to be published with the CLI. Without this, some more expensive solution like chunking would be required.
Fixes #270