fix: expose UnpackElectron

develar · Jun 24, 2019 · 1c4bfb2 · 1c4bfb2
1 parent 0514d72
commit 1c4bfb2
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/app-builder-bin/package.json b/app-builder-bin/package.json
@@ -1,7 +1,7 @@
 {
   "name": "app-builder-bin",
   "description": "app-builder precompiled binaries",
-  "version": "3.0.0",
+  "version": "3.0.1",
   "files": [
     "*.js",
     "mac",

diff --git a/main.go b/main.go
@@ -41,7 +41,7 @@ func main() {
 		return
 	}
 
-	var app = kingpin.New("app-builder", "app-builder").Version("3.0.0")
+	var app = kingpin.New("app-builder", "app-builder").Version("3.0.1")
 
 	node_modules.ConfigureCommand(app)
 	//codesign.ConfigureCommand(app)

diff --git a/pkg/electron/electronUnpack.go b/pkg/electron/electronUnpack.go
@@ -25,11 +25,11 @@ func ConfigureUnpackCommand(app *kingpin.Application) {
 		if err != nil {
 			return err
 		}
-		return unpackElectron(configs, *outputDir, *distMacOsAppName, true)
+		return UnpackElectron(configs, *outputDir, *distMacOsAppName, true)
 	})
 }
 
-func unpackElectron(configs []ElectronDownloadOptions, outputDir string, distMacOsAppName string, isReDownloadOnFileReadError bool) error {
+func UnpackElectron(configs []ElectronDownloadOptions, outputDir string, distMacOsAppName string, isReDownloadOnFileReadError bool) error {
 	cachedElectronZip := make(chan string, 1)
 	err := util.MapAsync(2, func(taskIndex int) (func() error, error) {
 		if taskIndex == 0 {
@@ -48,10 +48,15 @@ func unpackElectron(configs []ElectronDownloadOptions, outputDir string, distMac
 			}, nil
 		}
 	})
+
 	if err != nil {
 		return err
 	}
 
+	if len(distMacOsAppName) == 0 {
+		distMacOsAppName = "Electron"
+	}
+
 	excludedFiles := make(map[string]bool)
 	excludedFiles[filepath.Join(outputDir, distMacOsAppName, "Contents", "Resources", "default_app.asar")] = true
 	excludedFiles[filepath.Join(outputDir, "resources", "default_app.asar")] = true
@@ -72,7 +77,7 @@ func unpackElectron(configs []ElectronDownloadOptions, outputDir string, distMac
 				log.WithError(err).WithField("file", zipFile).Warn("cannot delete")
 			}
 
-			return unpackElectron(configs, outputDir, distMacOsAppName, false)
+			return UnpackElectron(configs, outputDir, distMacOsAppName, false)
 		} else {
 			return err
 		}