fix: Use config.mirror first before env variables for download URL #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue around download URL calculation as discovered in electron-userland/electron-builder#6445 (comment)
It doesn't make sense that we look at the env variables first before user-configured values. It took me hours to troubleshoot why my custom electron binary url wasn't taking when using the
mirrorconfiguration option and realized through console logging various packages that my env var hasNPM_CONFIG_ELECTRON_MIRRORset.This PR re-orders how the URL is calculated by first checking the
config.Mirroroption first before the env vars.