Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TextButton - rename tokens #532

Closed
2 tasks done
Tracked by #552
thrbnhrtmnn opened this issue Nov 6, 2023 · 0 comments
Closed
2 tasks done
Tracked by #552

TextButton - rename tokens #532

thrbnhrtmnn opened this issue Nov 6, 2023 · 0 comments
Assignees
@larserbach @ChristianHoffmannS2
Labels
🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Milestone
Rename Component ...

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Nov 6, 2023 •
edited
Loading

Description / User Story

After changing the structure of the component tokens within #239 , we now need to adjust the token names for the TextButton.

Acceptance Criteria

  • Design: All tokens used in the TextButton are following the new token naming
  • Dev: All tokens used in the TextButton are following the new token naming

Background information

  • Link to new token naming documentation
@thrbnhrtmnn thrbnhrtmnn added this to the Release 1.0 milestone Nov 6, 2023
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Nov 6, 2023
Closed
27 tasks
@thrbnhrtmnn thrbnhrtmnn added the 📋 task::ready Task is ready to be picked up or planned in label Nov 9, 2023
ChristianHoffmannS2 added a commit that referenced this issue Nov 13, 2023
@ChristianHoffmannS2
Merge branch 'develop' into #532-IconButton
b68b992
ChristianHoffmannS2 added a commit that referenced this issue Nov 13, 2023
@ChristianHoffmannS2
Merge branch 'develop' into #532-IconButton
fe5eecd
ChristianHoffmannS2 added a commit that referenced this issue Nov 14, 2023
@ChristianHoffmannS2 @larserbach
#532 icon button (#583)
8441d97 
* refactors icon button and icon dropdown

* fix(ui-library): preperation fior renaming action to actions

* feat: Adds Actions.[cmp].BorderRadius.[scale]
for textbutton, textdropdown, iconButton, iconDropdown, stepperButton

* fix typo

* feat(ui-library): test if icon button has an icon

* commit before pull

* handled focus

* fixed icon button inside tabbar

---------

Co-authored-by: larserbach <larserbach@users.noreply.github.com>
@thrbnhrtmnn thrbnhrtmnn mentioned this issue Nov 14, 2023
Closed
19 tasks
DenizSaganak pushed a commit that referenced this issue Nov 15, 2023
@ChristianHoffmannS2 @larserbach @DenizSaganak
#532 icon button (#583)
e99eb2a 
* refactors icon button and icon dropdown

* fix(ui-library): preperation fior renaming action to actions

* feat: Adds Actions.[cmp].BorderRadius.[scale]
for textbutton, textdropdown, iconButton, iconDropdown, stepperButton

* fix typo

* feat(ui-library): test if icon button has an icon

* commit before pull

* handled focus

* fixed icon button inside tabbar

---------

Co-authored-by: larserbach <larserbach@users.noreply.github.com>
@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers and removed 📋 task::ready Task is ready to be picked up or planned in labels Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larserbach larserbach

@ChristianHoffmannS2 ChristianHoffmannS2

Labels
🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Projects
None yet
Milestone
Rename Component Tokens
Development

No branches or pull requests
3 participants
@larserbach @ChristianHoffmannS2 @thrbnhrtmnn